[WIP] [Kernel] New tests for Timestamp_NTZ writes #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description This PR builds on top of PR#4159 and adds new unit tests for timestampNtz writes. Most of the write functionality (e.g. creation, inserts, insert with partition columns) are already exercised by DeltaTableWritesSuite. This PR adds a few more tests. ## How was this patch tested? New UTs.
vkorukanti
approved these changes
Feb 25, 2025
| @@ -1323,4 +1325,65 @@ class DeltaTableWritesSuite extends DeltaTableWriteSuiteBase with ParquetSuiteBa | |||
| assert(meta.get(ColumnMapping.COLUMN_MAPPING_PHYSICAL_NAME_KEY) == expPhyName) | |||
| } | |||
| } | |||
|
|
|||
| test("create table TIMESTAMP_NTZ type should auto-enable the reader/writer feature") { | |||
There was a problem hiding this comment.
can we move these tests to DeltaTableFeaturesSuite?
There was a problem hiding this comment.
I think there are utilities to check if the protocol contains certain features.
| } | ||
| } | ||
|
|
||
| test("create table without TIMESTAMP_NTZ type should use minimum protocol") { |
There was a problem hiding this comment.
we can combine this test and above one with
Seq(
// Test format: isTimestamp enabled, expected protocol
(true, new Protocol(3, 7, Set("timestampNtz"), Set("timetampNtz"),
(false, new Protocol(1, 2, Set.empty, Set.empty)
) {
case (isTimestampEnabled, expProtocol) => {
... test code ...
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of PR#4159 and adds new unit tests for timestampNtz writes.
Most of the write functionality (e.g. creation, inserts, insert with partition columns)
are already exercised by DeltaTableWritesSuite. This PR adds a few more tests.