Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W7M1 - Updates and Maintenance 01/05/24 #232

Merged
merged 6 commits into from
May 20, 2024

Conversation

jonbrenas
Copy link
Collaborator

Addresses #193 for this module.
Addresses #199 for this module.
Addresses #224 for this module.

Resolves #226 (it was a subclass of #199).
Resolves #227.

@jonbrenas jonbrenas requested review from alimanfoo, cclarkson and ahernank and removed request for alimanfoo, cclarkson and ahernank May 1, 2024 14:50
@jonbrenas
Copy link
Collaborator Author

jonbrenas commented May 9, 2024

Addresses #233 for this module.

We still need to address the absence of GM-L_colu_2006 from the CNVs.

Copy link
Collaborator

@ahernank ahernank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonbrenas. A minor comment:

  • We might need to change We get 130 amino acid changes from our coluzzii cohorts to We get **159** amino acid changes from our coluzzii cohorts as we get more of these from the df now.

@jonbrenas
Copy link
Collaborator Author

Thanks @ahernank. Good catch. This should be correct now.

@ahernank ahernank merged commit 7a09149 into master May 20, 2024
1 check passed
@ahernank ahernank deleted the w7m1-updates-and-maintenance-010524 branch May 20, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

W7M1 - French Typo (and also a bit English) W7M1 - So much new data!
2 participants