Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W5M1 update #239

Merged

Conversation

KellyLBennett
Copy link
Contributor

Changes to sample_set and global changes outlined in issues #193 #199 #224.

Warning below also supressed.
/home/conda/developer/2835ffd46e5535e81e9672d0828c143d4f1444491ac44f0aeddd90156919e446-20240426-081151-481742-64-training-nb-maintenance-mgen-9.0.0/lib/python3.10/site-packages/malariagen_data/anoph/snp_frq.py:1203: FutureWarning: 'A' is deprecated and will be removed in a future version, please use 'Y' instead.
return pd.Period(freq="A", year=year)

Resolves #216

@ahernank
Copy link
Collaborator

ahernank commented May 6, 2024

Thanke @KellyLBennett, there seem to be a couple of broken images here; it might be good to identify & get these fixed too.

@KellyLBennett
Copy link
Contributor Author

@ahernank It looks like the missing images are these (taken as screenshots from the video).

Screenshot 2024-05-07 at 09 48 46
Screenshot 2024-05-07 at 09 49 25

@KellyLBennett
Copy link
Contributor Author

Do you know how to fix these images?

@KellyLBennett
Copy link
Contributor Author

KellyLBennett commented May 7, 2024

@ahernank
Copy link
Collaborator

ahernank commented May 7, 2024

Copy link
Collaborator

@ahernank ahernank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KellyLBennett. It seems that some of the URLs related to documentation are broken, e.g. https://malariaatlas.org/research-project/metrics-of-insecticide-treated-nets-distribution/ -- it would be great to update this (and any other, if there are) to reflect the current location of this data.

@ahernank
Copy link
Collaborator

ahernank commented May 7, 2024

Thanks, just noticed a small typo on the text below, so this matches with the xarray results:

Here we can see some of the coordinate values. E.g., the first column of grid squares corresponds to the longitude value -17.979.

@ahernank ahernank self-requested a review May 7, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

W5M1 access CNV calls
2 participants