Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W7M3 - Updates and Maintenance 06/05/24 #243

Merged
merged 3 commits into from
May 22, 2024

Conversation

jonbrenas
Copy link
Collaborator

Addresses #193 for this module.
Addresses #199 for this module.
Addresses #224 for this module.

Resolves #241.

Copy link
Collaborator

@ahernank ahernank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jonbrenas. It might be worth updating the text on By default, the function will use all samples in the '3.0' release. referring to ag3.plot_haplotype_clustering, as this one will now grab all 3.0 + 3.x samples by default.

@ahernank
Copy link
Collaborator

Thinking a bit about this again, might be best to just delete the By default, the function will use all samples in the '3.0' release. line instead, to avoid confusion.

@jonbrenas
Copy link
Collaborator Author

Thanks @ahernank. I removed the not very helpful and confusing text.

@ahernank ahernank merged commit 63f14d4 into master May 22, 2024
1 check passed
@ahernank ahernank deleted the w7m3-updates-and-maintenance-060524 branch May 22, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

W7M3 - haplotype clusterings do not render
2 participants