Skip to content

Commit

Permalink
fix for Ansibe issue#149 (#153)
Browse files Browse the repository at this point in the history
* fix for Ansibe issue#149

* fix for ansible sanity

---------

Co-authored-by: prasada.reddy <[email protected]>
  • Loading branch information
prasadapr and prasada.reddy authored Oct 12, 2023
1 parent d081061 commit ece6c28
Show file tree
Hide file tree
Showing 6 changed files with 25 additions and 6 deletions.
1 change: 0 additions & 1 deletion .github/workflows/ansible-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ jobs:
matrix:
ansible:
- stable-2.10
- stable-2.11
- stable-2.12
- stable-2.13
- stable-2.14
Expand Down
9 changes: 9 additions & 0 deletions changelogs/CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,15 @@ Ansible Network Collection for Dell EMC SmartFabric OS10 Release Notes

.. contents:: Topics

v1.2.2
======

Bugfixes
--------

- Fixed issue in os10_command and os10_config modules to breaks prompt/answer (https://github.com/ansible-collections/dellemc.os10/issues/149)


v1.2.1
======

Expand Down
10 changes: 10 additions & 0 deletions changelogs/changelog.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -164,3 +164,13 @@ releases:
that have been added after the release of ``dellemc.os10`` 1.2.0.'
release_date: '2023-08-30'
1.2.2:
changes:
bugfixes:
- Fixed issue in os10_command and os10_config modules to breaks prompt/answer (https://github.com/ansible-collections/dellemc.os10/issues/149)
release_summary: 'This is the bug fix of the ``dellemc.os10`` collection.
This changelog contains all changes to the modules in this collection
that have been added after the release of ``dellemc.os10`` 1.2.1.'
release_date: '2023-10-12'
3 changes: 2 additions & 1 deletion galaxy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ authors:
- Parameswaran Krishnamurthy <[email protected]>
- Senthil Ganesan Ganesan <[email protected]>
- Shreeja R <[email protected]>
- Prasada Reddy <[email protected]>
dependencies:
ansible.netcommon: '>=2.0.0,<3.0.0'
description: Ansible Network Collection for Dell EMC SmartFabric OS10
Expand All @@ -10,7 +11,7 @@ name: os10
namespace: dellemc
readme: README.md
tags: [dell, dellemc, os10, emc, networking]
version: 1.2.1
version: 1.2.2
repository: https://github.com/ansible-collections/dellemc.os10
documentation: https://github.com/ansible-collections/dellemc.os10/tree/master/docs
homepage: https://github.com/ansible-collections/dellemc.os10
Expand Down
4 changes: 2 additions & 2 deletions plugins/modules/os10_command.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
module is not returned until the condition is satisfied or
the number of retries has expired.
type: list
elements: str
elements: raw
required: true
wait_for:
description:
Expand Down Expand Up @@ -169,7 +169,7 @@ def main():
argument_spec = dict(
# { command: <str>, prompt: <str>, response: <str> }
# commands=dict(type='list', required=True),
commands=dict(type='list', required=True, elements='str'),
commands=dict(type='list', required=True, elements='raw'),

wait_for=dict(type='list', elements='str'),
match=dict(default='all', choices=['all', 'any']),
Expand Down
4 changes: 2 additions & 2 deletions plugins/modules/os10_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
command syntax as some commands are automatically modified by the
device config parser. This argument is mutually exclusive with I(src).
type: list
elements: str
elements: raw
aliases: ['commands']
parents:
description:
Expand Down Expand Up @@ -249,7 +249,7 @@ def main():
dir_path=dict(type='path')
)
argument_spec = dict(
lines=dict(aliases=['commands'], type='list', elements='str'),
lines=dict(aliases=['commands'], type='list', elements='raw'),
parents=dict(type='list', elements='str'),

src=dict(type='path'),
Expand Down

0 comments on commit ece6c28

Please sign in to comment.