AAP-36005 Removed instances of de-supported options #2632
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the main option for now
jself-sudoku
commented
Nov 25, 2024
downstream/modules/eda/proc-eda-build-a-custom-decision-environment.adoc
Show resolved
Hide resolved
|
LGTM |
dhaustein
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Sans my question in https://github.com/ansible/aap-docs/pull/2632/files#r1857287254 looks go to me!
jself-sudoku
commented
Feb 21, 2025
There was a problem hiding this comment.
@bzwei - can you approve the content here now that the development work has been completed in https://issues.redhat.com/browse/AAP-36323?
bzwei
approved these changes
Feb 24, 2025
| @@ -17,15 +17,15 @@ You can create a custom decision environment for {EDAName} that provides a custo | |||
| .Procedure | |||
|
|
|||
| * Use `de-minimal` as the base image with {Builder} to build your custom decision environments. | |||
| This image is built from a base image provided by Red Hat at link:https://catalog.redhat.com/software/containers/ansible-automation-platform-25/de-supported-rhel9/650a5674ad524b664b693729[{PlatformNameShort} supported decision environment]. | |||
| This image is built from a base image provided by Red Hat at link:https://catalog.redhat.com/software/containers/ansible-automation-platform-25/de-minimal-rhel8/650a5671acdb2bef1d5d3a3b[{PlatformNameShort} minimal decision environment]. | |||
There was a problem hiding this comment.
is there a reason to point to the rhe8 image? Would it not be better to point to the rhel9 image?
https://catalog.redhat.com/software/containers/ansible-automation-platform-25/de-minimal-rhel9/650a5672a370728c710acaab
@jamesmarshall24 @jself-sudoku
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per instructions from meeting with SMEs,
de-supportedwill be replaced withde-minimalimages for decision environments, until further notice.Will refer to
de-minimalonly for now to prevent confusion for users. EDA collections have been added by @jamesmarshall24 tode-minimalimages for now.