Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test pipeline for triggering the e2e tests of the project #42

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

mabulgu
Copy link

@mabulgu mabulgu commented Dec 18, 2024

Description

This PR adds e2e test pipeline for triggering the e2e tests of the project

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

Jira issue: AAP-37403

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

mabulgu and others added 14 commits November 25, 2024 10:03
* aap customize package

* konflux references updates

* build-args for RAG content and folder path

* requirements.txt added for prod build
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
…mage-to-ansible-repo

Move RAG image to Ansible repository
@mabulgu mabulgu changed the title WIP | AAP-37403 - Add e2e test pipeline for triggering the e2e tests of the project Add e2e test pipeline for triggering the e2e tests of the project Dec 19, 2024
@mabulgu mabulgu marked this pull request as ready for review December 19, 2024 12:06

env:
branch: ${{ inputs.branch || 'main' }}
ols_url: ${{ inputs.environment == 'stage' && 'https://stage.ai.ansible.redhat.com/chat' || 'https://c.ai.ansible.redhat.com/chat' }}
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear reviewer, please consider this:

For the URLs here I used the ai connect chat urls but what we need here is the exposed urls of the chatbot service itself. if these current URLs give us what we need right now then it should be enough but otherwise for running the e2e tests as designed we need a route for each environment.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if this is sth we can discuss only when @TamiTakamiya returns, what I suggest is: let's merge this PR and that way we will be able to merge: https://github.com/ansible/ansible-wisdom-ops/pull/1179 and https://github.com/ansible/ansible-wisdom-ops/pull/1180

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't expose the chatbot service to the public. so only though the wisdom-service

@mabulgu mabulgu requested review from jameswnl and removed request for jameswnl December 19, 2024 14:14
Copy link

@jameswnl jameswnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mabulgu let's chat about this


env:
branch: ${{ inputs.branch || 'main' }}
ols_url: ${{ inputs.environment == 'stage' && 'https://stage.ai.ansible.redhat.com/chat' || 'https://c.ai.ansible.redhat.com/chat' }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't expose the chatbot service to the public. so only though the wisdom-service

@mabulgu
Copy link
Author

mabulgu commented Dec 25, 2024

Converting this to a draft upon our discussion with @jameswnl

@mabulgu mabulgu marked this pull request as draft December 25, 2024 13:47
@jameswnl jameswnl force-pushed the main branch 2 times, most recently from 01edb58 to d2a0706 Compare January 8, 2025 20:37
@TamiTakamiya TamiTakamiya force-pushed the main branch 3 times, most recently from 2e1e08e to e4805c1 Compare January 28, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants