-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AAP-38110] - Update Podman Dependancy #1180
Conversation
f1775d6
to
67e2fe4
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #1180 +/- ##
=======================================
Coverage 93.38% 93.38%
=======================================
Files 263 263
Lines 15050 15050
=======================================
Hits 14055 14055
Misses 995 995
Flags with carried forward coverage won't be shown. Click here to find out more. |
@@ -649,7 +649,7 @@ bcrypt = ["bcrypt"] | |||
|
|||
[[package]] | |||
name = "django-ansible-base" | |||
version = "2025.1.3" | |||
version = "2024.12.13" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you downgrading DAB? I don't think we need this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did not downgrade this on purpose, however when I ran poetry lock this happened automatically. This is a bit inconsistent though, as I see here - https://github.com/ansible/eda-server/pull/1180/files#diff-f53a023eedfa3fbf2925ec7dc76eecdc954ea94b7e47065393dbad519613dc89R688-R691
It is at 2025.1.3 still
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there might be some issue in your env. It should not set that version
This PR will update us to the latest version of podman.
It does not fix the port issue, but helps us sets us at the latest version of podman, so we can more easily update when we the fix is available.