Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AAP-38110] - Update Podman Dependancy #1180

Closed
wants to merge 1 commit into from

Conversation

zkayyali812
Copy link
Collaborator

This PR will update us to the latest version of podman.
It does not fix the port issue, but helps us sets us at the latest version of podman, so we can more easily update when we the fix is available.

Alex-Izquierdo
Alex-Izquierdo previously approved these changes Jan 23, 2025
@zkayyali812 zkayyali812 marked this pull request as ready for review January 23, 2025 20:01
@zkayyali812 zkayyali812 requested a review from a team as a code owner January 23, 2025 20:01
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.38%. Comparing base (b3fc0d9) to head (67e2fe4).

@@           Coverage Diff           @@
##             main    #1180   +/-   ##
=======================================
  Coverage   93.38%   93.38%           
=======================================
  Files         263      263           
  Lines       15050    15050           
=======================================
  Hits        14055    14055           
  Misses        995      995           
Flag Coverage Δ
unit-int-tests-3.11 93.32% <ø> (ø)
unit-int-tests-3.12 93.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@ -649,7 +649,7 @@ bcrypt = ["bcrypt"]

[[package]]
name = "django-ansible-base"
version = "2025.1.3"
version = "2024.12.13"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you downgrading DAB? I don't think we need this change.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not downgrade this on purpose, however when I ran poetry lock this happened automatically. This is a bit inconsistent though, as I see here - https://github.com/ansible/eda-server/pull/1180/files#diff-f53a023eedfa3fbf2925ec7dc76eecdc954ea94b7e47065393dbad519613dc89R688-R691
It is at 2025.1.3 still

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there might be some issue in your env. It should not set that version

@Alex-Izquierdo
Copy link
Collaborator

@zkayyali812 #1198

@zkayyali812 zkayyali812 deleted the zk/update/podman branch January 24, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants