Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Feature Flag Default to False #1222

Merged

Conversation

zkayyali812
Copy link
Collaborator

[AAP-XXXXX] Change FEATURE_EDA_ANALYTICS_ENABLED default to False

Description

Sets the default to False to align on feature requirements

Closes #XXX (if applicable)
Jira: AAP-XXXXX (if applicable)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test update
  • Refactoring (no functional changes)
  • Development environment change
  • Configuration change
  • CI change

Self-Review Checklist

  • I have performed a self-review of my code
  • I have added relevant comments to complex code sections
  • I have updated documentation where needed
  • I have considered the security impact of these changes
  • I have considered performance implications
  • I have thought about error handling and edge cases
  • I have tested the changes in my local environment
  • I have run the linters and test suite locally
  • I have tested the changes on integration environment

Testing Instructions

Prerequisites

Steps to Test

Expected Results

Additional Context

Required Actions

  • Requires documentation updates
  • Requires downstream repository changes
  • Requires infrastructure/deployment changes
  • Requires coordination with other teams
  • Blocked by PR/MR: #XXX | https://github.com/example/repo/pull/XXX

Screenshots/Logs

@codecov-commenter
Copy link

codecov-commenter commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (feature/analytics@2f0e092). Learn more about missing BASE report.

@@                 Coverage Diff                  @@
##             feature/analytics    #1222   +/-   ##
====================================================
  Coverage                     ?   94.15%           
====================================================
  Files                        ?      289           
  Lines                        ?    17119           
  Branches                     ?        0           
====================================================
  Hits                         ?    16119           
  Misses                       ?     1000           
  Partials                     ?        0           
Flag Coverage Δ
unit-int-tests-3.11 94.10% <ø> (?)
unit-int-tests-3.12 94.15% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/aap_eda/settings/default.py 89.11% <ø> (ø)

@zkayyali812 zkayyali812 marked this pull request as ready for review February 25, 2025 17:15
@zkayyali812 zkayyali812 requested a review from a team as a code owner February 25, 2025 17:15
@zkayyali812 zkayyali812 merged commit fa93589 into ansible:feature/analytics Feb 25, 2025
5 checks passed
@zkayyali812 zkayyali812 deleted the zk/analytics/default-false branch February 25, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants