-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust ALS .js.map files for debugging #1277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TamiTakamiya Can we please find another way to address this issue? -- one that does not adds extra copy-files or replace-text-in-files?
With the tsconfig consolidated by #1279 it should be much easier to reconfigure how we compile to make it work "by default" and without any tricks.
PS. I would prefer to make use of out/
folder, so we do not spam our source tree.
After rerunning the job, it succeeded. Let me run few more tests. |
I re-ran the test a couple of times, but could not recreate the issue. The log indicates there seem some timings that webpack set's its root dir to ALS's then attempts to compile extension's TypeScript code. Though I am going to merge this to main, I'll keep watching ci jobs if those issues re-appear. |
* Adjust ALS .js.map files for debugging * Simply the script to deal with macos issue * Redesign ALS source map support * Fix test error and remove old "withserver" scripts * test fix --------- Co-authored-by: Sorin Sbarnea <[email protected]>
When
npm run compile
copies ALS js/d.ts/js.map files from packages/ansible-language-server to out directory, we need to adjust the source path in .js.map files so that we can set breakpoints on TypeScript source files in debugging.