Added support for N-to-N filters like "concat" and dynamic inputs for A/V-to-N and N-to-A/V cases #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new component called DynamicFilterModal. This component is responsible for rendering a modal window that allows the user to add dynamic inputs and outputs to a selected filter. It also handles the logic for updating the selected filter with the new inputs and outputs. The DynamicFilterModal component is used in the FilterPicker component to provide a user-friendly interface for customizing filters. This commit addresses the following changes: - Added DynamicFilterModal.svelte file - Imported Modal component and addNode function in DynamicFilterModal.svelte - Defined props and variables in DynamicFilterModal.svelte - Implemented logic for adding dynamic inputs and outputs in DynamicFilterModal.svelte - Updated styles in DynamicFilterModal.svelte
refactor: out edges IDs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a modal popup for N->N, A/V-to-N, and N-to-A/V, which prompts the user to enter the variable number of inputs and their types. The order in which the user provides the inputs is respected in the preview state, making filters like "concat" smooth and intuitive (see examples for reference).
Updated the handling of audio/video outputs (from
out_aandout_v) to a count-based ID system (out_1,out_2). This fixes issues whereout_awas being duplicated (e.g.,ffmpeg -i x "[0:v][0:v] filter [out_a][out_a]" -map [out_a] y) and also opens the door for multi-output commands (if implemented).Revised tests to use the new
(out_COUNT)ID system instead of the old(out_TYPE)format.Two new examples demonstrating how the new N->N filters work were added.
Fixed the annoying
vidPlayerRef.seekToNextFrameerror.Added comments to improve code readability and understanding.
"This is my first time using Svelte, so I may have missed some optimization tweaks." 👀