Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add const MSG_MAX_LEN, the max size of Openflow message #56

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

hongliangl
Copy link

@hongliangl hongliangl commented Feb 6, 2024

This constant represents the maximum size of an OpenFlow message in bytes.
It can be utilized by other projects using this library.

@hongliangl hongliangl force-pushed the 20240206-add-max-message-size branch 2 times, most recently from 768e54d to e1adbef Compare February 6, 2024 06:30
const (
// Referring to page 43 in https://opennetworking.org/wp-content/uploads/2014/10/openflow-switch-v1.5.1.pdf,
// an OpenFlow message size can reach up to 64KB.
OFP_MESSAGE_MAX_SIZE = 64 * 1024
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value use 0xffff ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@hongliangl hongliangl force-pushed the 20240206-add-max-message-size branch 2 times, most recently from 19f6328 to e2c52e5 Compare February 6, 2024 08:50
@hongliangl hongliangl changed the title Add const OFP_MESSAGE_MAX_SIZE, the max size of Openflow message Add const MSG_MAX_LEN, the max size of Openflow message Feb 6, 2024
@hongliangl hongliangl force-pushed the 20240206-add-max-message-size branch 2 times, most recently from 1606276 to c03160e Compare February 6, 2024 08:54
This constant represents the maximum size of an OpenFlow message in bytes.
It can be utilized by other projects using this library.

Signed-off-by: Hongliang Liu <[email protected]>
@hongliangl hongliangl force-pushed the 20240206-add-max-message-size branch from c03160e to a96d564 Compare February 6, 2024 08:59
Copy link

@wenyingd wenyingd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyingd wenyingd merged commit f8e71bf into antrea-io:main Feb 6, 2024
4 checks passed
@hongliangl hongliangl deleted the 20240206-add-max-message-size branch February 6, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants