fix: svg path element A command drawing abnormality #1874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aarebecca
approved these changes
Dec 20, 2024
wang1212
added a commit
that referenced
this pull request
Dec 20, 2024
* fix: lineDash支持多位数组 (#1867) * chore: add changeset * fix: rendering error when line break appears at the beginning of text (#1871) * docs: 修复异常示例 * refactor: reduce global redundant code (#1872) * refactor: reduce global redundant code * chore: add changeset * fix: svg path element A command drawing abnormality (#1874) * Version Packages (#1869) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: HuangLiangchen <[email protected]> Co-authored-by: wang1212 <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
fixed #1844
💡 Background and solution
When
markerStartOffset/markerEndOffsetare set for the path element, the processing of theAcommand differs between canvas and svg. svg directly offsets the last two parameters of theAcommand, while canvas appends anLcommand.Considering the complexity of the
Acommand, the logic of svg is kept consistent with canvasto ensure that existing products that rely on this feature work properly.
📝 Changelog
☑️ Self Check before Merge