New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serialization of JSON::Any? nil values #227

Open

mloughran wants to merge 1 commit into anykeyh:master from mloughran:fix-json-any-nil-serialization

mloughran commented Jul 24, 2022

Description

Currently the literal string 'null' is written to the database when a nil value is serialized.

Note that the json_serializable_converter macro already does the right thing: https://github.com/anykeyh/clear/blob/master/src/clear/model/converters/json_any_converter.cr#L59

How Has This Been Tested?

A test has been added.
There were no existing tests for Clear::Model::Converter::JSON::AnyConverter.to_db.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Manual of usage of the new feature.

Checklist:

My code follows the code style of this project. bin/ameba ran without alert.
My change requires a change to the documentation.
I have updated the documentation accordingly.


          Fix serialization of JSON::Any? nil values

5e6baf6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet