qe: fix all infractions to clippy::needless_borrow (prisma#3926)

query-engine/black-box-tests/tests/helpers.rs

@@ -47,7 +47,7 @@ pub(crate) fn query_engine_cmd(dml: &str, port: &str) -> process::Command {
 pub(crate) fn query_engine_bin_path() -> path::PathBuf {
     let name = "query-engine";
     let env_var = format!("CARGO_BIN_EXE_{}", name);
-    std::env::var_os(&env_var)
+    std::env::var_os(env_var)
         .map(|p| p.into())
         .unwrap_or_else(|| target_dir().join(format!("{}{}", name, env::consts::EXE_SUFFIX)))
 }

query-engine/black-box-tests/tests/protocols/mismatched.rs

@@ -1,7 +1,7 @@
 use crate::helpers::*;
 use query_engine_tests::*;
 
-const JSON_QUERY: &'static str = r###"
+const JSON_QUERY: &str = r###"
 {
     "action": "findMany",
     "modelName": "Person",
@@ -15,7 +15,7 @@ const JSON_QUERY: &'static str = r###"
 }
 "###;
 
-const GRAPHQL_QUERY: &'static str = r###"
+const GRAPHQL_QUERY: &str = r###"
 {
   "operationName": null,
   "variables": {},

query-engine/connectors/mongodb-query-connector/src/error.rs

@@ -290,6 +290,6 @@ impl<T> DecorateErrorWithFieldInformationExtension for crate::Result<T> {
     }
 
     fn decorate_with_composite_field_info(self, cf: &CompositeFieldRef) -> Self {
-        self.map_err(|err| err.decorate_with_field_name(&cf.name()))
+        self.map_err(|err| err.decorate_with_field_name(cf.name()))
     }
 }

query-engine/connectors/mongodb-query-connector/src/lib.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::vec_init_then_push, clippy::branches_sharing_code, clippy::needless_borrow)]
+#![allow(clippy::vec_init_then_push, clippy::branches_sharing_code)]
 
 mod constants;
 mod cursor;

query-engine/connectors/mongodb-query-connector/src/root_queries/aggregate.rs

@@ -14,7 +14,7 @@ pub async fn aggregate<'conn>(
     having: Option<Filter>,
 ) -> crate::Result<Vec<AggregationRow>> {
     let is_group_by = !group_by.is_empty();
-    let coll = database.collection(&model.db_name());
+    let coll = database.collection(model.db_name());
 
     let query = MongoReadQueryBuilder::from_args(query_arguments)?
         .with_groupings(group_by, &selections, having)?
@@ -88,7 +88,7 @@ fn to_aggregation_rows(
         let mut id_key_doc = doc.remove(group_by::UNDERSCORE_ID).unwrap();
 
         for selection in selections.iter() {
-            let selection_meta = output_meta::from_aggregation_selection(&selection);
+            let selection_meta = output_meta::from_aggregation_selection(selection);
 
             match selection {
                 // All flat selection can only be in the _id part of the result doc.
@@ -101,15 +101,15 @@ fn to_aggregation_rows(
                 AggregationSelection::Count { all, fields } => {
                     if *all {
                         let meta = selection_meta.get("all").unwrap();
-                        let field_val = value_from_bson(doc.remove("count_all").unwrap(), &meta)?;
+                        let field_val = value_from_bson(doc.remove("count_all").unwrap(), meta)?;
 
                         row.push(AggregationResult::Count(None, field_val));
                     }
 
                     for field in fields {
                         let meta = selection_meta.get(field.db_name()).unwrap();
                         let bson = doc.remove(&format!("count_{}", field.db_name())).unwrap();
-                        let field_val = value_from_bson(bson, &meta)?;
+                        let field_val = value_from_bson(bson, meta)?;
 
                         row.push(AggregationResult::Count(Some(field.clone()), field_val));
                     }

query-engine/connectors/mongodb-query-connector/src/root_queries/write.rs

@@ -105,7 +105,7 @@ pub async fn create_records<'conn>(
                     .try_into()
                     .expect("Create calls can only use PrismaValue write expressions (right now).");
 
-                let bson = (field, value).into_bson().decorate_with_field_info(&field)?;
+                let bson = (field, value).into_bson().decorate_with_field_info(field)?;
 
                 doc.insert(field_name.to_string(), bson);
             }
@@ -342,7 +342,7 @@ pub async fn m2m_connect<'conn>(
 
             (selection, value.clone())
                 .into_bson()
-                .decorate_with_selected_field_info(&selection)
+                .decorate_with_selected_field_info(selection)
         })
         .collect::<crate::Result<Vec<_>>>()?;
 
@@ -408,7 +408,7 @@ pub async fn m2m_disconnect<'conn>(
 
             (field, value.clone())
                 .into_bson()
-                .decorate_with_selected_field_info(&field)
+                .decorate_with_selected_field_info(field)
         })
         .collect::<crate::Result<Vec<_>>>()?;
 

query-engine/connectors/mongodb-query-connector/src/value.rs

@@ -129,7 +129,7 @@ impl IntoBson for (&MongoDbType, PrismaValue) {
     fn into_bson(self) -> crate::Result<Bson> {
         Ok(match self {
             // ObjectId
-            (MongoDbType::ObjectId, PrismaValue::String(s)) => Bson::ObjectId(ObjectId::parse_str(&s)?),
+            (MongoDbType::ObjectId, PrismaValue::String(s)) => Bson::ObjectId(ObjectId::parse_str(s)?),
             (MongoDbType::ObjectId, PrismaValue::Bytes(b)) => {
                 if b.len() != 12 {
                     return Err(MongoError::MalformedObjectId(format!(

query-engine/connectors/sql-query-connector/src/cursor_condition.rs

@@ -218,7 +218,7 @@ pub(crate) fn build(
             let cursor_condition = cursor_row.clone().equals(cursor_values.clone());
 
             // Orderings for this query. Influences which fields we need to fetch for comparing order fields.
-            let mut definitions = order_definitions(query_arguments, model, &order_by_defs, ctx);
+            let mut definitions = order_definitions(query_arguments, model, order_by_defs, ctx);
 
             // Subquery to find the value of the order field(s) that we need for comparison.
             let order_subquery = Select::from_table(model.as_table(ctx)).so_that(cursor_condition);
@@ -247,7 +247,7 @@ pub(crate) fn build(
                     let mut and_conditions = Vec::with_capacity(head.len() + 1);
 
                     for order_definition in head {
-                        and_conditions.push(map_equality_condition(&order_subquery, &order_definition));
+                        and_conditions.push(map_equality_condition(&order_subquery, order_definition));
                     }
 
                     let order_definition = tail.first().unwrap();
@@ -279,15 +279,15 @@ pub(crate) fn build(
                         // but everything else must come strictly "after" the cursor.
                         and_conditions.push(map_orderby_condition(
                             &order_subquery,
-                            &order_definition,
+                            order_definition,
                             reverse,
                             true,
                             ctx,
                         ));
                     } else {
                         and_conditions.push(map_orderby_condition(
                             &order_subquery,
-                            &order_definition,
+                            order_definition,
                             reverse,
                             false,
                             ctx,
@@ -519,7 +519,7 @@ fn cursor_order_def_relevance(order_by: &OrderByRelevance, order_by_def: &OrderB
 }
 
 fn foreign_keys_from_order_path(path: &[OrderByHop], joins: &[AliasedJoin]) -> Option<Vec<CursorOrderForeignKey>> {
-    let (before_last_hop, last_hop) = take_last_two_elem(&path);
+    let (before_last_hop, last_hop) = take_last_two_elem(path);
 
     last_hop.map(|hop| {
         match hop {

query-engine/connectors/sql-query-connector/src/database/connection.rs

@@ -52,7 +52,7 @@ where
             Some(level) => {
                 let transformed = IsolationLevel::from_str(&level)
                     .map_err(SqlError::from)
-                    .map_err(|err| err.into_connector_error(&connection_info))?;
+                    .map_err(|err| err.into_connector_error(connection_info))?;
 
                 Some(transformed)
             }

query-engine/connectors/sql-query-connector/src/database/operations/upsert.rs

@@ -25,7 +25,7 @@ pub(crate) async fn native_upsert(
     let where_condition = upsert.filter().aliased_condition_from(None, false, ctx);
     let update = build_update_and_set_query(upsert.model(), upsert.update().clone(), ctx).so_that(where_condition);
 
-    let insert = create_record(&upsert.model(), upsert.create().clone(), ctx);
+    let insert = create_record(upsert.model(), upsert.create().clone(), ctx);
 
     let constraints: Vec<_> = upsert.unique_constraints().as_columns(ctx).collect();
     let query: Query = insert

query-engine/connectors/sql-query-connector/src/database/sqlite.rs

@@ -74,7 +74,7 @@ fn invalid_file_path_error(file_path: &str, connection_info: &ConnectionInfo) ->
     SqlError::ConnectionError(QuaintKind::DatabaseUrlIsInvalid(format!(
         "\"{file_path}\" is not a valid sqlite file path"
     )))
-    .into_connector_error(&connection_info)
+    .into_connector_error(connection_info)
 }
 
 #[async_trait]

query-engine/connectors/sql-query-connector/src/lib.rs

@@ -1,9 +1,4 @@
-#![allow(
-    clippy::wrong_self_convention,
-    clippy::branches_sharing_code,
-    clippy::needless_borrow,
-    clippy::needless_collect
-)]
+#![allow(clippy::wrong_self_convention)]
 #![deny(unsafe_code)]
 
 mod column_metadata;

query-engine/connectors/sql-query-connector/src/query_builder/read.rs

@@ -59,7 +59,7 @@ impl SelectDefinition for QueryArguments {
         ctx: &Context<'_>,
     ) -> (Select<'static>, Vec<Expression<'static>>) {
         let order_by_definitions = OrderByBuilder::default().build(&self, ctx);
-        let cursor_condition = cursor_condition::build(&self, &model, &order_by_definitions, ctx);
+        let cursor_condition = cursor_condition::build(&self, model, &order_by_definitions, ctx);
         let aggregation_joins = nested_aggregations::build(aggr_selections, ctx);
 
         let limit = if self.ignore_take { None } else { self.take_abs() };
@@ -157,7 +157,7 @@ pub(crate) fn aggregate(
     args: QueryArguments,
     ctx: &Context<'_>,
 ) -> Select<'static> {
-    let columns = extract_columns(model, &selections, ctx);
+    let columns = extract_columns(model, selections, ctx);
     let sub_query = get_records(model, columns.into_iter(), &[], args, ctx);
     let sub_table = Table::from(sub_query).alias("sub");
 

query-engine/connectors/sql-query-connector/src/query_builder/write.rs

@@ -12,7 +12,7 @@ pub(crate) fn create_record(model: &ModelRef, mut args: WriteArgs, ctx: &Context
         .fields()
         .scalar()
         .into_iter()
-        .filter(|field| args.has_arg_for(&field.db_name()))
+        .filter(|field| args.has_arg_for(field.db_name()))
         .collect();
 
     let insert = fields

query-engine/query-engine-node-api/src/lib.rs

@@ -1,10 +1,9 @@
-#![allow(clippy::needless_borrow)]
-
 pub mod engine;
 pub mod error;
 pub mod functions;
 pub mod log_callback;
 pub mod logger;
+
 mod tracer;
 
 pub(crate) type Result<T> = std::result::Result<T, error::ApiError>;

query-engine/query-engine/src/main.rs

@@ -1,4 +1,4 @@
-#![allow(clippy::upper_case_acronyms, clippy::needless_borrow)]
+#![allow(clippy::upper_case_acronyms)]
 
 #[macro_use]
 extern crate tracing;