[SOL] Inform stack size in error message #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasSte
changed the title
dmakarov
approved these changes
Jul 1, 2024
LucasSte
merged commit 8bc30e8
into
anza-xyz:solana-rustc/17.0-2023-12-14
14 checks passed
LucasSte
added a commit
to LucasSte/llvm-project
that referenced
this pull request
Jul 4, 2024
LucasSte
added a commit
that referenced
this pull request
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The error message when a function accesses an offset greater than allowed does not inform the function frame size, hindering debugging. It only shows one of the accessed offsets, which is not necessarily the greatest one.
Solution
Inform the estimated frame size for that function.