[SOL] Change encoding of callx instruction
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
dmakarov
reviewed
Jan 3, 2024
|
I tested this change against the programs in I'm waiting to merge #77 so that I can rebase this PR and fix the conflicts before the review. |
I converted to a draft because I wanted to test it with real programs first. I also noticed I got the encoding wrong 😅 |
|
LGTM, please feel free to merge when the CI is done. |
Merging is blocked without an approval. |
LucasSte
merged commit 5502543
into
anza-xyz:solana-rustc/16.0-2023-06-05
14 checks passed
LucasSte
added a commit
to LucasSte/llvm-project
that referenced
this pull request
Jan 31, 2024
* Change encoding of callx instruction
LucasSte
added a commit
that referenced
this pull request
Feb 16, 2024
* Change encoding of callx instruction
LucasSte
added a commit
to LucasSte/llvm-project
that referenced
this pull request
Jun 28, 2024
* Change encoding of callx instruction
LucasSte
added a commit
that referenced
this pull request
Aug 19, 2024
* Change encoding of callx instruction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one of the tasks in solana-labs/solana#34250 to update the SBF target with the new instructions. Especially, this modification is the equivalent of solana-labs/rbpf#491 in LLVM, changing the encoding of the
callxinstruction.There was a small refactoring in the table gen files to encompass a new
SubtargetFeature. AsFeatureCallxRegSrcwas required both inSBF.tdand inSBFInstrInfo.td, I put all the feature in a new file to avoid a circular dependency.