[SOL] Add tests for call (nfc) #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Refer to #41 |
dmakarov
approved these changes
Jan 9, 2024
LucasSte
merged commit fbbce8d
into
anza-xyz:solana-rustc/16.0-2023-06-05
15 checks passed
LucasSte
added a commit
to LucasSte/llvm-project
that referenced
this pull request
Jan 31, 2024
LucasSte
added a commit
that referenced
this pull request
Feb 16, 2024
LucasSte
added a commit
to LucasSte/llvm-project
that referenced
this pull request
Jun 28, 2024
LucasSte
added a commit
that referenced
this pull request
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents another task in solana-labs/solana#34250. The modifications made in solana-labs/rbpf#296 incur no functional change in the LLVM backend. We are already emitting src=1 for SBF-to-SBF calls and src=0 for external calls.
As the encoding for calls was not tested, I added a some tests to ensure we follow such a pattern.