Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update toolchain to rustc/17.0 2023 12 14 #85

Conversation

LucasSte
Copy link
Collaborator

No description provided.

jackcmay and others added 30 commits January 26, 2024 17:40
…a-xyz#4)

* [BPF] Make rust allocation builtins unavailable for BPF target

- the calls to rust alloc/dealloc routines need to be preserved and
not replaced by compiler generated builtin inlined code
* [SOL][BPF] Adjust BPF tests

* [SOL][BPF] Improve reporting of stack size is too large

- issue only one warning for each function
- report the function location if debug information is available
* [SOL] Make lld thread-safe with llvm when used in-process

Every time Solang tries to link a web-assembly file in-process, the linker
re-inits llvm which is not thread-safe with the rest of solang.

Signed-off-by: Sean Young <[email protected]>

* [SOL][BPF] Enable the _ExtInt extension on the BPF Target for Solana

Signed-off-by: Sean Young <[email protected]>
Solana extends BPF so that structs type information is not fully
supported in BTF.  This leads to ICE crashes and some unsupported
relocations being emitted in binary files that linker errors on.
For, now the debug information is simply disabled when compiling
for Solana to avoid the errors in Debug builds.
dmakarov and others added 20 commits January 30, 2024 18:41
Because of a bug in BPF backend ABS64 relocations are incorrectly
generated as 64_64 relocations in BPF object files. This temporary
works around this for relocations in .debug section to generate debug
information addresses correctly.
This change rust-lang@ab4fc87
breaks compilation of compiler-rt library for BPF and SBF targets.
For now disabling it.
These tests currently fail on some Macs for some versions of Python,
causing our CI to fail.

See, e.g., llvm#62403 and references
therein.
This PR replaces sub r11, imm by add r11, -imm and is the equivalent of solana-labs/rbpf#488 for the SBF target in LLVM.

This is the first task in solana-labs/solana#34250
Patch anza-xyz#54 originally
reworked the SBF textual assembly syntax to match the rbpf-style syntax.

In order to allow some soak-time, the above patch temporarily supported
both the old and new syntax (selectable on the command line or via bespoke
assembler directives). A little over a year has passed since then,
and all is well with the new syntax, testing, and so forth.

The current patch now removes all existing remnants of the old syntax--
including some of the target-independent changes made in the original
patch to support both (e.g., a minor TableGen change for variants, some
additional command line selector flags, etc).

All related unit tests have been updated accordingly.
Following the alterations made in solana-labs/rbpf#489, this PR removes the neg instructions and changes the semantics of sub when one of the operands is an immediate.

sub r1, 2 now means r1 = 2 - r1, instead of r1 = r1 - 2.
neg r1 is represented as r1 = 0  - r1.

This is the second task in solana-labs/solana#34250.
This PR addressed two more items in solana-labs/solana#34250.
It removes the little endian byte swap instructions (solana-labs/rbpf#493)
and the input buffers related instructions (solana-labs/rbpf#251).
* Remove lddw instruction

* Add suggestions
* Fix incorrect obj-dump

* Read flag from elf
* Change encoding of callx instruction
* Fix out of pattern name

* Remove deprecated function
@LucasSte LucasSte force-pushed the solana-rustc/17.0-2023-12-14 branch from d1a9f2c to 216ab27 Compare February 1, 2024 12:35
@LucasSte LucasSte marked this pull request as ready for review February 5, 2024 20:06
@LucasSte LucasSte requested review from dmakarov and removed request for dmakarov February 5, 2024 20:07
@LucasSte LucasSte marked this pull request as draft February 5, 2024 22:18
@LucasSte LucasSte requested a review from dmakarov February 6, 2024 00:51
@LucasSte LucasSte marked this pull request as ready for review February 6, 2024 00:57
@LucasSte LucasSte merged commit 7416428 into anza-xyz:solana-rustc/17.0-2023-12-14 Feb 16, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants