-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Loot and Tradeskill window #2
Open
DBFBlackbull
wants to merge
21
commits into
anzz1:master
Choose a base branch
from
DBFBlackbull:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DBFBlackbull
commented
Oct 26, 2023
•
edited
Loading
edited
- Indented the code to use tabs
- Refactored the code to set the price into a function
- Added support for the loot window
- Added support for the tradeskill window
- Added support for item links to also show a sell value
Tradeskill prices
Fixed error that occurs in combination with EQL3. The error specifically happens when you open the quest log, then mouse over a creature (or maybe other object creating a info window) and then mousing over the quest log item again. The quest log item does not produce a box with item information, which causes the links to fail. The underlying bug is highly likely hidden somewhere inside EQL3, but I do not know how to find it there.
Improved hack so that single reward quests still work.
- Added git ignore
Removed the logging
Updated readme with roll sell price
- inbox mail cannot be done because the link function was only implemented in Cata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.