Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with ARDC processing #48

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Fix bug with ARDC processing #48

merged 3 commits into from
Apr 29, 2024

Conversation

vietnguyengit
Copy link
Collaborator

No description provided.

@vietnguyengit
Copy link
Collaborator Author

bug causing categories like "Air temperature" (second-level) doesn't have "broader" (top-level) therefore, further process of categories suggestion couldn't suggest "Air temperature"

Copy link
Collaborator

@utas-raymondng utas-raymondng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but can you add a test case for this?

Copy link
Collaborator

@utas-raymondng utas-raymondng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, test will be in another PR

@utas-raymondng utas-raymondng merged commit d17abab into main Apr 29, 2024
2 checks passed
@utas-raymondng utas-raymondng deleted the fix-ardc-bug branch April 29, 2024 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants