-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AMQ-8324] Add design doc for Jakarta Messaging 3.1 asynchronous send #1390
base: main
Are you sure you want to change the base?
Conversation
I don't really like the use of images as they are not easily modifiable. Markdown supports code blocks (and you can mark it as java) so I would use something like that instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Image is fine for design diagram/schema.
However, it should not be used for code.
Instead we should use the markdown code block: the huge advantage is that we can suggest change during the review.
@@ -0,0 +1,225 @@ | |||
# Jakarta Messaging 3.1: asynchronous send design doc | |||
|
|||
Date: Jan 5th 2025 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not add date here (the PR date is good enough 😄 ).
+1 for this |
Use codeblock instead of image. |
Add design doc for implementing Jakarta Messaging 3.1 asynchronous send per the latest process discussed on dev list.
Note to reviewers, GitHub rich diff doesn't render image properly. You can click "view file" from the hamburger button to see the rendered markdown.