Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AMBARI-26233: Fix ambari-env.sh after jdk upgrade #3873

Open
wants to merge 3 commits into
base: upgrade/jdk-spring-dependencies
Choose a base branch
from
Open

AMBARI-26233: Fix ambari-env.sh after jdk upgrade #3873

wants to merge 3 commits into from

Conversation

JiaLiangC
Copy link
Contributor

@JiaLiangC JiaLiangC commented Nov 8, 2024 •
edited
Loading

What changes were proposed in this pull request?

  1. Remove the JVM parameters for the Ambari agent, as they are not needed. In the trunk branch, there are no JVM parameters in the Ambari agent's ambari-env.
  2. Add default values to the Ambari server's environment, otherwise, there will be an error due to missing JVM parameters during startup.
  3. Remove JVM parameters that are incompatible with JDK 17.

How was this patch tested?

unit tests, manual tests
(If this patch involves UI changes, please attach a screen-shot; otherwise, remove this)

Please review Ambari Contributing Guide before opening a pull request.

@JiaLiangC JiaLiangC mentioned this pull request Nov 8, 2024
Open
virajjasani
virajjasani approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@virajjasani virajjasani virajjasani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JiaLiangC @virajjasani