Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make IngressClass creation optional #799

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −0
Open

feat: make IngressClass creation optional #799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions charts/apisix-ingress-controller/templates/ingress-class.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.config.kubernetes.createIngressClass }}
{{ if or (eq .Values.config.kubernetes.ingressVersion "") (eq .Values.config.kubernetes.ingressVersion "networking/v1")}}
apiVersion: networking.k8s.io/v1
{{- else if (eq .Values.config.kubernetes.ingressVersion "networking/v1beta1")}}
Expand All @@ -10,3 +11,4 @@ metadata:
name: {{ .Values.config.kubernetes.ingressClass | quote }}
spec:
controller: apisix.apache.org/apisix-ingress # fix: https://github.com/apache/apisix-ingress-controller/issues/1653
{{- end }}
2 changes: 2 additions & 0 deletions charts/apisix-ingress-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,8 @@ config:
# only the leader will watch and delivery resource changes,
# other instances (as candidates) stand by.
electionId: "ingress-apisix-leader"
# Set to false to disable IngressClass creation
createIngressClass: true
# -- The class of an Ingress object is set using the field IngressClassName in
# Kubernetes clusters version v1.18.0 or higher or the annotation
# "kubernetes.io/ingress.class" (deprecated).
Expand Down
Loading