chore: upgrade openresty version to v1.27.11 #11936
Open
+8
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreemaan-abhishek
force-pushed
the
12711
branch
from
a4993f9 to
0454f25
Compare
dosubot
bot
added
size:S
membphis
approved these changes
Feb 6, 2025
| @@ -188,7 +188,7 @@ routes: | |||
| GET /hello | |||
| --- error_code: 502 | |||
| --- error_log | |||
| upstream: "grpc://127.0.0.1:80" | |||
| connect() failed (111: Connection refused) while connecting to upstream | |||
There was a problem hiding this comment.
this change is needed as grpc proxy is done under subrequest, and the apisix custom logger (in apisix-nginx-module) overrides the original log handler of nginx and stores the reference to the original log handler in ctx.
but ngx_stash_ctx fails to store reference to that log handler. Thus the original log handler doesn't get executed and the upstream: "grpc: ..." field in error log is not present.
| @@ -258,7 +258,8 @@ function _M.set(matched_ssl, sni) | |||
| local reject_in_handshake = | |||
| (ngx.config.subsystem == "stream") or | |||
| (matched_ssl.value.client.skip_mtls_uri_regex == nil) | |||
| local ok, err = ngx_ssl.verify_client(parsed_cert, depth, | |||
| -- TODO: support passing `trusted_certs` (3rd arg, keep it nil for now) | |||
| local ok, err = ngx_ssl.verify_client(parsed_cert, depth, nil, | |||
There was a problem hiding this comment.
the verify client API has changed and it expects 4 parameters now, the 3rd parameter is trusted_certs, we can implement the support for trusted certs later.
Revolyssup
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrade openresty version to v1.27.1.1.
Checklist