-
Notifications
You must be signed in to change notification settings - Fork 884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable conditional put by default for S3 #7181
Conversation
1200e25
to
116c4ff
Compare
One potential issue with the approach in this PR is I don't think there is a way now to turn off conditional put support, perhaps we need to add a Disabled variant? |
Why and when would we need to disable |
The scenario is an S3-compatible that doesn't support the headers, and simply ignores them, I could see people wanting to disable support so that they get an error instead of silently incorrect behaviour. |
Ok, Let me add a |
116c4ff
to
d1e2c76
Compare
0048be2
to
0279ace
Compare
Which issue does this PR close?
Closes #7080
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
set
S3ConditionalPut::ETagMatch
as the default value forconditional_put
inAmazonS3Builder