Make reqwest an optional feature #7203
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Feb 26, 2025
| @@ -195,8 +198,10 @@ impl FromStr for ClientConfigKey { | |||
| /// This is used to configure the client to trust a specific certificate. See | |||
| /// [Self::from_pem] for an example | |||
| #[derive(Debug, Clone)] | |||
| #[cfg(feature = "reqwest")] | |||
There was a problem hiding this comment.
This is the only remaining place where reqwest leaks into the public API, this is somewhat hard to get away from because of its intertwining with the TLS machinery of reqwest.
tustvold
force-pushed
the
make-reqwest-optional
branch
from
0f35094 to
370cae7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
POC showing that the abstractions added in #7183 allow reqwest to be an optional feature.
I'm not entirely sure whether we should merge this, it seems unfortunate to force users to opt-in to reqwest, but it at least shows that this is possible
What changes are included in this PR?
Are there any user-facing changes?