Make flight tonic error boxed #7229
Open
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
arrow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
When working on the nightly rust, I noticed that clippy warns about
FlightErrortoo large, more than 176 bytes.I think it makes sense to keep the error small (32 bytes), as the Result<...> is used in a lot of places.
This PR basically makes
Tonic(tonic::Status)intoTonic(Box<tonic::Status>), which reduces the FlightError from 176 bytes down to 32 bytes.This adds an extra allocation on error, but should probably be fine as it's not on hot path.
What changes are included in this PR?
Are there any user-facing changes?