[Dataflow Streaming] do not spam logs when onNext called on closed St…

…reamObserver (#33977)
apache · Feb 13, 2025 · 1b29e5f · 1b29e5f
1 parent 27f9fe9
commit 1b29e5f
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/...apache/beam/runners/dataflow/worker/windmill/client/ResettableThrowingStreamObserver.java b/...apache/beam/runners/dataflow/worker/windmill/client/ResettableThrowingStreamObserver.java
@@ -122,12 +122,9 @@ public void onNext(T t) throws StreamClosedException, WindmillStreamShutdownExce
       try {
         delegate.onError(cancellationException);
       } catch (IllegalStateException onErrorException) {
-        // If the delegate above was already terminated via onError or onComplete from another
-        // thread.
-        logger.warn(
-            "StreamObserver was already cancelled {} due to error.",
-            onErrorException,
-            cancellationException);
+        // The delegate above was already terminated via onError or onComplete.
+        // Fallthrough since this is possibly due to queued onNext() calls that are being made from
+        // previously blocked threads.
       } catch (RuntimeException onErrorException) {
         logger.warn(
             "Encountered unexpected error {} when cancelling due to error.",