another round of comments

apache · Jan 17, 2025 · 925290b · 925290b
1 parent f02a194
commit 925290b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/...rg/apache/beam/runners/dataflow/worker/MetricsToPerStepNamespaceMetricsConverterTest.java b/...rg/apache/beam/runners/dataflow/worker/MetricsToPerStepNamespaceMetricsConverterTest.java
@@ -83,7 +83,7 @@ public double getAccumulatedBucketSize(int endIndex) {
   }
 
   @Test
-  public void testConvert_successfulyConvertCounters() {
+  public void testConvert_successfullyConvertCounters() {
     String step = "testStepName";
     Map<MetricName, LockFreeHistogram.Snapshot> emptyHistograms = new HashMap<>();
     Map<MetricName, Long> counters = new HashMap<MetricName, Long>();
@@ -374,7 +374,7 @@ public void testConvert_convertCountersAndHistograms() {
   }
 
   @Test
-  public void testConvert_successfulyConvertGauges() {
+  public void testConvert_successfullyConvertGauges() {
     String step = "testStepName";
     Map<MetricName, LockFreeHistogram.Snapshot> emptyHistograms = new HashMap<>();
     Map<MetricName, Long> counters = new HashMap<MetricName, Long>();

diff --git a/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaMetrics.java b/sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaMetrics.java
@@ -79,8 +79,6 @@ abstract class KafkaMetricsImpl implements KafkaMetrics {
 
     abstract ConcurrentHashMap<String, ConcurrentLinkedQueue<Duration>> perTopicRpcLatencies();
 
-    static ConcurrentHashMap<String, Gauge> backlogGauges = new ConcurrentHashMap<String, Gauge>();
-
     abstract ConcurrentHashMap<String, Long> perTopicPartitionBacklogs();
 
     abstract AtomicBoolean isWritable();