sdks/python: enable recursive deletion for GCSFileSystem Paths #33611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
In this commit, we enable recursive deletion for GCS (Google Cloud Storage) paths, including directories and blobs. Changes include: - Updated the `delete` method to support recursive deletion of GCS directories (prefixes). - If the path points to a directory, all blobs under that prefix are deleted. - Refactored logic to handle both single blob and directory deletion cases.
In this commit, we update the delete test to verify recursive deletion of directories (prefixes) in GCS. Changes include: - Added test for deleting a GCS directory (prefix) with multiple files. - Verified files under a directory are deleted recursively when using the delete method.
mohamedawnallah
force-pushed
the
enableRecursiveDeleteGCS
branch
from
1ea7e3b to
01a4b65
Compare
|
Assigning reviewers. If you would like to opt out of this review, comment R: @tvalentyn for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Hi @liferoad, It seems the test cases passed now. I would love to receive any feedback on that PR! 🙏 |
|
Ack. Thanks for contributing to Beam. I will review the code today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, we enable recursive deletion for Google Cloud Storage (GCS) paths, including directories and blobs. The
deletemethod is updated to remove all blobs under a directory (prefix) when deleting GCS directories.Additionally, we update the delete test to verify the recursive deletion of directories containing multiple files.
Changes include:
deletemethod to support recursive directory deletion.Fixes #27605
Current Behavior
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.