[BEAM-2530] More fixes/upgrades for Java 9 compatibility #4685
Conversation
iemejia
force-pushed
the
BEAM-2530-java9-morefixes
branch
2 times, most recently
from
8c20983 to
000fc7a
Compare
|
Ok, last fixes applied, a really neat progress, notice that almost all Java 9 specific parts are hidden in self-activated profiles, its functionality should be moved into gradle when the time is appropriate. I will soon start to fill specific JIRAs for the pending breaking tests and once that the fix for classloading gets decided and merged (#4497 or #4514). |
sdks/java/io/xml/pom.xml
Outdated
| </activation> | ||
| <dependencies> | ||
| <!-- | ||
| These deps should be explilctly defined for Java 9 compat |
pom.xml
Outdated
| @@ -413,6 +417,61 @@ | |||
| </build> | |||
| </profile> | |||
|
|
|||
| <profile> | |||
| <id>java-next</id> | |||
There was a problem hiding this comment.
Cool name, but is there a reason for java-next instead of java-9? I actually guess that with the timelines we might be testing with Java 8, 9, 10 at the same time.
There was a problem hiding this comment.
Well the thing I was thinking is that we probably should define our target if we will go for the whole spectrum (9.10,11) or if we asume like the milestone will be the LTS version (11). I will rename it to 9 and we will see how we evolve it depending pn the future releases.
iemejia
force-pushed
the
BEAM-2530-java9-morefixes
branch
from
000fc7a to
38ffebb
Compare
|
retest this please |
Apart of the fixes it introduces an auto activated profile when using Java 9.
Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue.mvn clean verifyto make sure basic checks pass. A more thorough check will be performed on your pull request automatically.