Fixes soap linkage error #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
could you add a comment saying what is removed, and/or do this as two commits one which copies the stock jre.properties value and another which removes the relevant ones? also this will fix it only for jre 1.8. i wonder whether we'd be better off overwriting the original so glad it's fixed though!!! |
added 2 commits
November 20, 2020 16:48
When soap returns some errors Brooklyn doesn't manage to deserialise them and instead shows a linkage error. This is documented in this issue here:cloudsoft/winrm4j#129
duncangrant
force-pushed
the
fix-winrm-soapfault
branch
from
7cbf78a to
c59269e
Compare
|
@ahgittin I've split this into 2 commits to make it clear what has been removed. Although this only fixes the issue for java 8, the equivalent packages are included in java 9 + so I don't think it should be an issue there. |
|
LGTM - merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When soap returns some errors Brooklyn doesn't manage to deserialise
them and instead shows a linkage error.
This is documented in this issue
here:cloudsoft/winrm4j#129