Pass relation Oid to smgr_AORelOpenSegFile. #956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
my-ship-it
reviewed
Feb 25, 2025
| @@ -104,13 +104,18 @@ static f_smgr smgrsw[SMGR_MAX_ID + 1] = { | |||
| } | |||
| }; | |||
|
|
|||
| static File AORelOpenSegFile(__attribute__((unused))Oid reloid, const char *filePath, int fileFlags) | |||
There was a problem hiding this comment.
Why are we doing this, but oid is not used here? Is it because we replace the function pointer in the extension?
There was a problem hiding this comment.
Because we cannot assing PathNameOpenFile to smgr_AORelOpenSegFile now, signature is changed.
reshke
force-pushed
the
pass_ooid_to_aorelopenfile
branch
2 times, most recently
from
8131cdb to
35d4150
Compare
fix unittest
reshke
force-pushed
the
pass_ooid_to_aorelopenfile
branch
from
35d4150 to
3363508
Compare
x4m
approved these changes
Feb 27, 2025
|
@my-ship-it hi! How do you like this version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smgr_* Functions, including smgr_AORelOpenSegFile, were added to CDBD in order to support compute/storage separation solutions, optimized for append load (in few words, for https://github.com/yezzey-gp/yezzey to work). Yezzey uses current segment file relation OIDs in its internal logic. It is not necessary to pass OID each time we call smgr_AORelOpenSegFile, because extension can perform syscahe lookup.
A ratio for this change is to save few CPU cycles where possible.
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions