Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick a few handy commits. #957

Merged
merged 5 commits into from
Feb 26, 2025
Merged

Cherry-pick a few handy commits. #957

merged 5 commits into from
Feb 26, 2025

Conversation

reshke
Copy link
Contributor

@reshke reshke commented Feb 23, 2025

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


@my-ship-it
Copy link
Contributor

my-ship-it commented Feb 25, 2025

It is duplicated with PR #917 and related issue #930.

@reshke
Copy link
Contributor Author

reshke commented Feb 25, 2025

It is duplicated with PR #917 and related issue #930.

Thank your for pointing this out. It seems like pr #917 was not merged yet. I can remove commit about GDD, because I only need subset of changes from it for pg_stat_progress AO index tests. Does it sound OK?

alvherre and others added 4 commits February 25, 2025 13:09
The existing wording wasn't clear enough and some details weren't
anywhere, such as the fact that autosummarization is off by default.
Improve.

Authors: Roberto Mello, Jaime Casanova, Justin Pryzby, Álvaro Herrera
Discussion: https://postgr.es/m/CAKz==bK_NoJytRyQfX8K-erCW3Ff7--oGYpiB8+ePVS7dRVW_A@mail.gmail.com
Discussion: https://postgr.es/m/[email protected]
It's moved from intRelOpts_gp to boolRelOpts_gp in commit
ddd80abb1aba5b812fb085ad516dcee6c9e130f3 by mistake. Moving it back.
…te (#13822)

Why : In previous PR 13757 where the plan was to check the health of the cluster before starting the expansion in gpexpand. while backporting in 6x we realised that hard exit after the health check will create problem for the customer when due to some reason they will not able to make the cluster up in balance state. this will block customer to expand.

Issue : we found the root cause as when the cluster is not in balance state then the max/min port is returning wrong port values and as result system is expanding at the wrong port which is giving multi port error.

Fix: updated the function to work in imbalance cluster state scenario. we are collecting all the port for primary and mirror based on preferred role of the segment, and if the role is switched we are considering segmentPairs.mirrorDB for primary port and segmentPairs.primaryDB for mirror port. in this we are collecting the port which is based on the preferred role.

another change in the pr is, instead of error exit in imbalance scenario we are just logging the warning.

Added unit test cases for the positive/negative and exception scenario for the newly added functions. Updated feature test case where we are converting error to warning.
…ansactions

Previously, CREATE INDEX could hang if there was a pre-existing
read-only transaction accessing to the same AO/CO table. This is
because index creation on AO/CO table requires acquiring
AccessExclusiveLock which could be blocked by existing readers
holding the shared lock.

This patch is to allow index creation on AO/CO working concurrently
with read-only transactions, replace AccessExclusiveLock with
ShareRowExclusiveLock to avoid blocking each other.
@reshke
Copy link
Contributor Author

reshke commented Feb 25, 2025

I removed Lock leaf partitions for Insert Statement when GDD disabled.

@reshke reshke force-pushed the wal_brin branch 2 times, most recently from 0c50feb to 6ff7c26 Compare February 25, 2025 15:32
@reshke reshke merged commit 5cdbab1 into apache:main Feb 26, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants