Add attribute encoding to partition roots #974
Draft
+1,428
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds pg_attribute_encoding entries for root partitions, During create statement, we add attribute encoding entries to catalog If the table has a parent partition, and no options or encodings are specified, we copy the parent partition's encoding entries For partitioned table create statement, we pick the explicitly defined column encoding for the parent over the table-level option defined for the child partition. The storage encoding clause for a column is picked as follows: * 1. An explicit encoding clause in the ColumnDef of self/parent * 2. A column reference storage directive for this column * 3. A default column encoding in the statement * 4. Parent partition's column encoding values * 5. A default for the type. Add attribute encodings to d+ description for root partitions Added tests to check comlumn encoding inheritance priority
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds pg_attribute_encoding entries for root partitions, During create statement, we add attribute encoding entries to catalog If the table has a parent partition, and no options or encodings are specified, we copy the parent partition's encoding entries
For partitioned table create statement, we pick
the explicitly defined column encoding for the parent over the table-level option defined for the child partition.
The storage encoding clause for a column is picked as follows:
Add attribute encodings to d+ description for root partitions
Added tests to check comlumn encoding inheritance priority
Fixes #ISSUE_Number
What does this PR do?
Type of Change
Breaking Changes
Test Plan
make installcheckmake -C src/test installcheck-cbdb-parallelImpact
Performance:
User-facing changes:
Dependencies:
Checklist
Additional Context
CI Skip Instructions