Revert test of #10267

[DaanHoogland]

Reverts #10267 "server: fix attach uploaded volume"

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 5.88235% with 32 lines in your changes missing coverage. Please review.

Project coverage is 15.12%. Comparing base (238d0c5) to head (56e173b).
Report is 6 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...n/java/com/cloud/storage/VolumeApiServiceImpl.java	5.88%	32 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #10323      +/-   ##
============================================
- Coverage     15.16%   15.12%   -0.05%     
+ Complexity    11306    11303       -3     
============================================
  Files          5408     5409       +1     
  Lines        473948   476627    +2679     
  Branches      57851    58480     +629     
============================================
+ Hits          71883    72098     +215     
- Misses       394029   396473    +2444     
- Partials       8036     8056      +20     

Flag	Coverage Δ
uitests	4.22% <ø> (-0.08%)	⬇️
unittests	15.86% <5.88%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12326

[DaanHoogland]

@blueorangutan test matrix

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

[blueorangutan]

[SF] Trillian test result (tid-12297)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48224 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10323-t12297-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

[blueorangutan]

[SF] Trillian test result (tid-12299)
Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57017 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10323-t12299-vmware-70u3.zip
Smoke tests completed. 131 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	Error	482.57	test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	Error	482.60	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	Error	590.05	test_internal_lb.py
test_12_destroy_cpvm	Error	6.38	test_ssvm.py

[blueorangutan]

[SF] Trillian test result (tid-12298)
Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22
Total time taken: 57948 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10323-t12298-kvm-ubuntu22.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_unsecure_vm_migration	Error	249.03	test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration	Error	164.85	test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration	Error	160.83	test_vm_life_cycle.py

[shwstppr]

@DaanHoogland I think we can proceed with this. Though I feel #10267 probably wasn't the reason for whole test suite failure but based on #10324 (comment) I think there is a behavioural change which is causing test_12_start_vm_multiple_volumes_allocated failure. I'll check and fix.

[blueorangutan]

[SF] Trillian test result (tid-12300)
Environment: xcpng82 (x2), Advanced Networking with Mgmt server ol9
Total time taken: 70487 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10323-t12300-xcpng82.zip
Smoke tests completed. 131 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_condensed_drs_algorithm	Failure	171.06	test_cluster_drs.py
test_02_balanced_drs_algorithm	Failure	185.36	test_cluster_drs.py
test_01_non_strict_host_anti_affinity	Error	231.73	test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity	Error	132.23	test_nonstrict_affinity_group.py

[DaanHoogland]

@DaanHoogland I think we can proceed with this. Though I feel #10267 probably wasn't the reason for whole test suite failure but based on #10324 (comment) I think there is a behavioural change which is causing test_12_start_vm_multiple_volumes_allocated failure. I'll check and fix.

ok @shwstppr , I will still want to see #10267 results as #10322 doesn't show these results. cc @weizhouapache @JoaoJandre

[DaanHoogland]

as showing the results of #10267 (comment) is not the reason either. closing this one.

[weizhouapache]

@DaanHoogland
#10267 has the test failures but #10323 (revert of #10267) does not.

can we say #10267 caused the test failures ?

[DaanHoogland]

@DaanHoogland #10267 has the test failures but #10323 (revert of #10267) does not.

can we say #10267 caused the test failures ?

@weizhouapache the results of #10267 (comment) show that #10267 does not have the same 47/57 long list of failures and we need to keep looking

#10267 (comment)
#10267 (comment)
#10267 (comment)
#10267 (comment)

[weizhouapache]

@DaanHoogland #10267 has the test failures but #10323 (revert of #10267) does not.
can we say #10267 caused the test failures ?

@weizhouapache the results of #10267 (comment) show that #10267 does not have the same 47/57 long list of failures and we need to keep looking

#10267 (comment) #10267 (comment) #10267 (comment) #10267 (comment)

the massive test failures seen in some tests are intermitted I think.
the test results of this PR is ok.

I was talking about the test failure test_12_start_vm_multiple_volumes_allocated, which appeared in the test results of #10267 but not in this PR.

[DaanHoogland]

ok, after backtalk with @shwstppr and @weizhouapache I am merging this.

[sonarqubecloud]

Quality Gate failed

Failed conditions
4.5% Coverage on New Code (required ≥ 40%)

See analysis details on SonarQube Cloud