fix(create): Copy config.xml data during creation #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpogue
force-pushed
the
create-config
branch
from
2659421 to
2c94f45
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1502 +/- ##
==========================================
+ Coverage 80.86% 80.97% +0.10%
==========================================
Files 16 16
Lines 1840 1850 +10
==========================================
+ Hits 1488 1498 +10
Misses 352 352 ☔ View full report in Codecov by Sentry. |
This ensures that by the time plugin installation happens, the preferences from the root application config.xml can be read as expected. Closes apacheGH-1422.
dpogue
force-pushed
the
create-config
branch
from
2c94f45 to
dc2587b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
Motivation and Context
This ensures that by the time plugin installation happens, the preferences from the root application config.xml can be read as expected.
Closes GH-1422.
Description
Merge the app's config.xml into the defaults.xml at creation time for the platform config.xml.
Also removed comments about the
linkoption since that's no longer relevant (with CordovaLib consumed as a Swift package, it is always linked).Testing
Existing tests pass, and added a new unit test to verify new behaviour.
Checklist