WIP: fix(android): Fix deprecated left shift usage (support was removed in Gradle 5) #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breautek
changed the title
breautek
commented
Jul 4, 2023
| doLast { | ||
| def contents = new HashMap() | ||
| def sizes = new HashMap() | ||
| contents["test"] = inAssetsDir.list() |
There was a problem hiding this comment.
Been 2 years since I created this PR so I don't remember the rationale, but this doesn't seem correct... especialyl since its being changed from contents[""] = ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
Fixes #425
Also required for #471
Description
Removed deprecated
<<syntax in Gradle (<<support was removed in Gradle 5) and replaced it with the equivalent.Testing
Manual tests
Checklist
(platform)if this change only applies to one platform (e.g.(android))