Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add simple complex type microbenchmark #1433

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Feb 20, 2025

Which issue does this PR close?

Part of #1043

Rationale for this change

We need to start running benchmarks for complex type support.

What changes are included in this PR?

OpenJDK 64-Bit Server VM 11.0.26+4-post-Ubuntu-1ubuntu122.04 on Linux 6.8.0-52-generic
AMD Ryzen 9 7950X3D 16-Core Processor
CometComplexTypeBenchmark:                          Best Time(ms)   Avg Time(ms)   Stdev(ms)    Rate(M/s)   Per Row(ns)   Relative
----------------------------------------------------------------------------------------------------------------------------------
ComplexTypeBenchmark - Spark                                   20             22           2          0.0     1951297.0       1.0X
ComplexTypeBenchmark - Comet native_comet                      20             23           2          0.0     2000735.9       1.0X
ComplexTypeBenchmark - Comet native_datafusion                 19             22           3          0.0     1904497.2       1.0X
ComplexTypeBenchmark - Comet native_iceberg_compat             17             20           2          0.0     1743933.5       1.1X

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 39.34%. Comparing base (f09f8af) to head (b076a0c).
Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
.../scala/org/apache/comet/serde/QueryPlanSerde.scala 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #1433       +/-   ##
=============================================
- Coverage     56.12%   39.34%   -16.79%     
- Complexity      976     2087     +1111     
=============================================
  Files           119      265      +146     
  Lines         11743    61172    +49429     
  Branches       2251    12982    +10731     
=============================================
+ Hits           6591    24066    +17475     
- Misses         4012    32589    +28577     
- Partials       1140     4517     +3377     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants