-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add read array support #1456
base: main
Are you sure you want to change the base?
Conversation
spark/src/test/scala/org/apache/comet/exec/CometNativeReaderSuite.scala
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1456 +/- ##
============================================
+ Coverage 56.12% 58.73% +2.60%
- Complexity 976 1018 +42
============================================
Files 119 122 +3
Lines 11743 12255 +512
Branches 2251 2308 +57
============================================
+ Hits 6591 7198 +607
+ Misses 4012 3899 -113
- Partials 1140 1158 +18 ☔ View full report in Codecov by Sentry. |
Some tests are failing due to #1289 I think the root cause is that we are trying to shuffle with arrays and Comet shuffle does not support arrays yet. We need to fall back to Spark for these shuffles. |
In @comphead Do you want to update these checks as part of this PR and see if it resolves the issue? case class CometExecRule(session: SparkSession) extends Rule[SparkPlan] {
private def applyCometShuffle(plan: SparkPlan): SparkPlan = {
plan.transformUp {
case s: ShuffleExchangeExec
if isCometPlan(s.child) && isCometNativeShuffleMode(conf) &&
QueryPlanSerde.supportPartitioning(s.child.output, s.outputPartitioning)._1 =>
...
case s: ShuffleExchangeExec
if (!s.child.supportsColumnar || isCometPlan(s.child)) && isCometJVMShuffleMode(
conf) &&
QueryPlanSerde.supportPartitioningTypes(s.child.output, s.outputPartitioning)._1 &&
!isShuffleOperator(s.child) =>
... |
Thanks @andygrove I'll check that, you saving me hours of debugging |
Which issue does this PR close?
Closes #1454 .
Rationale for this change
What changes are included in this PR?
How are these changes tested?