Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note there is an alternate approach that is not an API change that uses a dedicated builder in #10636, but then I realized that
there were many fields (like
enable_page_index
etc that could already be set with builder apis on ParquetExec so making them redundant with ParquetExec seemed uncessaryWhich issue does this PR close?
Part of #10546
Rationale for this change
While working on #10549 it was cumbersome
to create a
ParquetExec
-- specifically there are a few fields onParquetExec::new
thatmust always be provided even though they are
Option
s and most of the rest of the options can be set via builder styleAPIs like
with_schema_adapter_factory
In addition, some fields like
schema_adapter_factory
can not be set by constructor but are instead setby builder function
with_schema_adapater_factor
.Thus it is confusing and imposes a cognitive load that the properties setting is inconsistent.
What changes are included in this PR?
ParquetExec::new
Are these changes tested?
Yes by existing CI
Are there any user-facing changes?
This is a user API change for anyone who creates ParquetExec's directly (as we do in InfluxDB IOx for example)
There is also better documentation