Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support serialization and deserialization limit in the aggregation exec #10692

Merged
merged 1 commit into from
May 28, 2024

Conversation

liukun4515
Copy link
Contributor

Which issue does this PR close?

Closes #10630

Rationale for this change

  1. add new struct message AggLimit
  2. add UT in the ser/deser test for this case

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@liukun4515 liukun4515 changed the title (feat): support limit in agg exec for ser/deser in the proto file support limit in agg exec for ser/deser in the proto file May 28, 2024
@liukun4515 liukun4515 changed the title support limit in agg exec for ser/deser in the proto file support serialize and deserialize limit in the aggregation exec May 28, 2024
@liukun4515
Copy link
Contributor Author

cc @avantgardnerio @alamb

@liukun4515 liukun4515 force-pushed the ser_de_agg_limt_10630 branch from 6eefd1f to e9f23d2 Compare May 28, 2024 06:56
@liukun4515 liukun4515 changed the title support serialize and deserialize limit in the aggregation exec support serialization and deserialization limit in the aggregation exec May 28, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @liukun4515

@alamb alamb merged commit 70a215b into apache:main May 28, 2024
24 checks passed
@liukun4515
Copy link
Contributor Author

Looks good to me -- thank you @liukun4515

Thanks for your such amazing quick feedback.

@liukun4515 liukun4515 deleted the ser_de_agg_limt_10630 branch May 29, 2024 02:45
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The limit info lost in the AggregateExec when ser/deser the physical plan
2 participants