Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in bench.sh #10698

Merged
merged 1 commit into from
May 29, 2024
Merged

Fix typo in bench.sh #10698

merged 1 commit into from
May 29, 2024

Conversation

vimt
Copy link
Contributor

@vimt vimt commented May 28, 2024

Which issue does this PR close?

Closes #.

Rationale for this change

Change 1

I meet error when I try to run command ./bench.sh data tpch10_mem as described in usage.

Error: unknown benchmark 'tpch10_mem' for data generation

I think this is due to a typo in usage

Change 2

And when I open bench.sh, IDE tells me that there is an error in the main function.

main references arguments, but none are ever passed.
See SC2120.

The main function is called without passing any arguments, but there is such code BRANCH1=$1 and BRANCH2=$2

What changes are included in this PR?

  1. Fix typo
  2. Calling compare_benchmarks with parameter passing

Are these changes tested?

I tested it manually with bash -x

Are there any user-facing changes?

No

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vimt

@alamb alamb added the development-process Related to development process of DataFusion label May 29, 2024
@alamb alamb merged commit 2006088 into apache:main May 29, 2024
24 checks passed
findepi pushed a commit to findepi/datafusion that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants