Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start refactoring process by setting up base + init #14306

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
+6,435 −0
Open

start refactoring process by setting up base + init #14306

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
cda0145
start refactoring process by setting up base + init
logan-keede Jan 26, 2025
3254063
fix: forgotten init file
logan-keede Jan 26, 2025
c0150d4
Readme + archival of old/complete aggregate
logan-keede Jan 27, 2025
61d1560
fix: empty forgotten README
logan-keede Jan 27, 2025
d5f0ed8
fix: prettier formatting
logan-keede Jan 27, 2025
2499af0
Update datafusion/sqllogictest/test_files/aggregate/README.md
logan-keede Jan 27, 2025
6bb002b
diff functionality
logan-keede Jan 27, 2025
3017cf1
Merge branch 'aggregate_refactor_properly' of https://github.com/loga…
logan-keede Jan 27, 2025
5959740
checks to make sure there are no changes in base_aggregate and comple…
logan-keede Jan 27, 2025
0aaa778
fix: Clippy
logan-keede Jan 27, 2025
5ac5596
improve code quality
logan-keede Feb 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...ion/sqllogictest/test_files/aggregate.slt → ...llogictest/archive/complete_aggregate.slt
View file
Open in desktop
File renamed without changes.
14 changes: 14 additions & 0 deletions datafusion/sqllogictest/test_files/aggregate/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
# Aggregate Tests

##### History and Context:

Aggregate used to be (perhaps still is depending on the progress on issue [#13723](https://github.com/apache/datafusion/issues/13723)).
We have decided to refactor it for better navigation by using `extract and subtract` approach.

Formally, `base_aggregate.slt` starts with all the test cases of original `aggregate.slt` which is currently in `datafusion/sqllogictest/archive`.

Gradually, as we move out(`extract`) different portions of code we remove(`substract`) only that protion from `base_aggregate.slt`.

It should be done in a manner that at all times set of all tests in aggregate folder is a superset of all tests covered in `datafusion/sqllogictest/archive/complete_aggregate.slt`

Refer to [#14301](https://github.com/apache/datafusion/pull/14301) and [#14306](https://github.com/apache/datafusion/pull/14306) for more context and details.
Loading
Loading