-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase MSRV to 1.81.0 #14330
Increase MSRV to 1.81.0 #14330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alamb
we also need to change it in
datafusion-cli/Dockerfile
And here .devcontainer/Dockerfile
looks like the version is missing which doesn't seem to be correct imho as it takes latest rustc
Thanks everyone; I want to merge this in to unblock a bunch of the other dependency upgrades. I will make a follow on PR to change this one:
|
BTW @comphead I think using the latest Rust in the dev container makes sense -- there is no reason why it needs to use the oldest rust supported by DataFusion (the MSRV) Perhaps we should actually change the DataFusion CLI dockerfile the same way 🤔 |
apache/datafusion#14330 Signed-off-by: Yuchen Liang <[email protected]>
apache/datafusion#14330 Signed-off-by: Yuchen Liang <[email protected]>
## Problem With the initial representation and storage added in #4 and #22, we now want to support the full pipeline going from parsing SQL, optimizing the plan using optd, and executing the query in Datafusion. ## Summary of changes - Integrate all @SarveshOO7's good work in #10 - Added one mock physical implementation rule + operator for each logical operator - Refactor scalar operator storage and reduce code bloat. - Add physical storage tables and memo API. - Bump MSRV to 1.81.0 to be compatible with datafusion 45.0.0: apache/datafusion#14330 --------- Signed-off-by: Yuchen Liang <[email protected]> Co-authored-by: SarveshOO7 <[email protected]>
Which issue does this PR close?
Rationale for this change
Per the policy: https://github.com/apache/datafusion?tab=readme-ov-file#rust-version-compatibility-policy
The most recent versions are
1.81
,1.82
,1.83
,1.84
https://github.com/rust-lang/rust/blob/master/RELEASES.md
Several of our dependencies now have a MSRV of 1.81
What changes are included in this PR?
Update MSRV to 1.81
Are these changes tested?
Are there any user-facing changes?