feat: implement contextualized ObjectStore #14805
Draft
+106
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
See #14804
What changes are included in this PR?
Introduce new
ContextualizedObjectStore
type that implementsobject_store::ObjectStore
.Are these changes tested?
I haven't written any tests for this behavior in datafusion yet and would like guidance from maintainers with respect to what kind of testing they think would be good here.
I also still need to manually test that this does the thing I want it to do with respect to tracing in a caching
ObjectStore
implementation in https://github.com/influxdata/influxdbAre there any user-facing changes?
Only if the user registers a custom
ObjectStore
implementation with datafusion and wants to pass opaque data (like tracing spans) from various places in the call stack leading up to query execution -- after this they will have access to that data in their custom implementation ofObjectStore.get_opts
when called during query execution.