Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unparser add AtArrow and ArrowAt conversion to BinaryOperator #14968

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Unparser add AtArrow and ArrowAt conversion to BinaryOperator #14968

wants to merge 1 commit into from
+18 −2

Conversation

cetra3
Copy link
Contributor

@cetra3 cetra3 commented Mar 3, 2025

Which issue does this PR close?

No Issue, just another production error we're seeing

Rationale for this change

This seems like a pretty straight forward change to support AtArrow and ArrowAt

@github-actions github-actions bot added the sql SQL Planner label Mar 3, 2025
alamb
alamb reviewed Mar 3, 2025
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cetra3 -- can you please add some tests so we make sure we don't break this feature in the future?

@alamb alamb marked this pull request as draft March 3, 2025 21:42
@cetra3 cetra3 force-pushed the unparser_at_arrow branch from f8cdaa6 to 2536486 Compare March 4, 2025 03:26
@cetra3
Copy link
Contributor Author

cetra3 commented Mar 4, 2025

@alamb I've added tests for both arms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
sql SQL Planner
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cetra3 @alamb