Improve SQL syntax error messages in parser (#14437) #14986
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #14437
Rationale for this change
The current SQL syntax error messages in DataFusion lack detailed context, making debugging difficult for users.
This PR improves error reporting by:
Showing unexpected tokens in the error message.
Displaying exact line and column numbers for better debugging.
Providing helpful hints when possible.
What changes are included in this PR?
Enhanced
parser_err!
macro** to include token details, line, and column.Modified
expected
function to return more precise error locations.Added a test case (
test_parser_error_message
) to verify the improved error messages.Are these changes tested?
Yes ✅
parser.rs
to check:Are there any user-facing changes?
Yes ✅