Skip to content

Commit

Permalink
1
Browse files Browse the repository at this point in the history
  • Loading branch information
wyxxxcat committed Jan 19, 2025
1 parent bb81eda commit 30e8de9
Show file tree
Hide file tree
Showing 2 changed files with 45 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,12 @@ public PartitionItem createAndCheckPartitionItem(SinglePartitionDesc desc, boole

// we might receive one whole empty values list, we should add default partition value for
// such occasion

if (partitionKeyDesc.getInValues() == null) {
throw new DdlException(
"Partitions types is invalid, expected In in list partitions");
}

for (List<PartitionValue> values : partitionKeyDesc.getInValues()) {
if (values.isEmpty()) {
continue;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.

suite("test_list_partition_invalid_add") {
sql "drop table if exists list_partition_invalid_add_tbl"
sql """
CREATE TABLE IF NOT EXISTS list_partition_invalid_add_tbl (
k1 int NOT NULL,
k2 bigint NOT NULL
)
PARTITION BY LIST(k1,k2) ()
DISTRIBUTED BY HASH(k1) BUCKETS 5 properties("replication_num" = "1")
"""

test{
sql """ alter table list_partition_invalid_add_tbl add partition p0 values [("0"), ("2")) """
exception "Partitions types is invalid, expected In in list partitions"
}

sql """ alter table list_partition_invalid_add_tbl add partition p0 values in (("0", "2")) """

def res = sql_return_maparray """ show partitions from list_partition_invalid_add_tbl where PartitionName = "p0" """

assertEquals(res[0].Range, "[types: [INT, BIGINT]; keys: [0, 2]; ]")
}

0 comments on commit 30e8de9

Please sign in to comment.